Authors:
chris_miller
SixRQ
Apache

Code Review

Products: Android Studio, IntelliJ IDEA

Vendor: Chris Miller

Email:

Website: N/A

SourceCode: https://github.com/klunk/Code-Review-Plugin

Description:

Allows a developer to send a code review email that details any changes to their code compared with the repository. This email is sent before anything is checked in, so colleagues can have a chance to review your changes before they are committed.
Downloads: 8756
Rating:
Participated in rating: 11
Version Since Build Until Build File/URL Size (Kb) Date Details
1.3.5. 123.123. . Download 1190.98 2013-02-01 19:13:27 details
1.3.3. . . Download 1955.97 2009-11-11 20:09:27 details
. .
8 updates are hidden show all updates
Screenshot #3250
Screenshot #3251

Recent change notes:


v1.3.5 for IDEA 12.0.2 and up (February 1st 2013) - Simon Wiehe

===========================================

  • [BUG] Build with JDK 1.6.


v1.3.4 for IDEA 12.0.2 and up (January 28th 2013) - Simon Wiehe

===========================================

  • [IMPROVEMENT] Give a meaningful explanation if the file sizes are too large to compare.
  • [BUG] Fix location of copy button icon.


v1.3.3 for IDEA 7.0.3 and up (November 11th 2009)

===========================================

  • [IMPROVEMENT] Provides better indication of whether binary files have been added/deleted/changed
  • [BUG] Deleted binary files were being treated as text files and as a result their content was showing in the emails


v1.3.2 for IDEA 7.0.3 and up (November 11th 2009)

===========================================

  • [IMPROVEMENT] Removed until-build attribute from plugin.xml so this plugin plays nicer with various IDEA builds and the (buggy?) Plugin Manager


v1.3.1 for IDEA 7.x and up (August 5th 2009)

===========================================

  • [IMPROVEMENT] Emails are now sent with UTF-8 encoding


v1.3.0 for IDEA 7.x and up (August 4th 2009)

===========================================

  • [NEW] Copy to clipboard button. This copies the HTML and/or plaintext to the clipboard
  • [NEW] SMTPS/SSL support. This allows the plugin to work with mailservers such as GMail
  • [IMPROVEMENT] When a file has been renamed, the diff now shows what it was renamed to
  • [IMPROVEMENT] The subject defaults to the (first 100 characters of) the commit message
  • [BUG] Passwords weren't being decoded properly when settings were first loaded
  • [BUG] Long subjects were causing the drop-downs to extend past the RHS of the Code Review dialog
  • [BUG] Pressing CTRL-ENTER when the focus was on the subject drop-down could result in changes to the subject being lost
  • [BUG] The Cancel button now returns the user to the Commit Changes dialog rather than the editor


v1.2.2 for IDEA 7.x (June 26th 2008)

===========================================

  • [IMPROVEMENT] When a diff fails due to a problem with the underlying VCS, more information is now shown in the error dialog to help diagnose the problem
  • [IMPROVEMENT] Minor cosmetic changes


v1.2.1 for IDEA 7.x (June 6th 2008)

===========================================

  • [BUG] The "to:" field wasn't populating it's history correctly
  • [BUG] Fixed spelling mistake


v1.2.0 for IDEA 7.x (April 18th 2008)

===========================================

  • [NEW] Option to ignore any trailing whitespace
  • [NEW] Original line numbers are now shown
  • [NEW] Added a button that copies the HTML to the clipboard
  • [NEW] Files are sorted by path
  • [NEW] More efficient memory usage
  • [BUG] Was throwing an exception when a binary file was encountered. Now indicates correctly that the file is binary


v1.1.0 for IDEA 6.0.2 (November 17th 2006)

===========================================

  • [NEW] A Zip file containing all the changed files can be attached to the email
  • [NEW] The drop-down histories now display items with the most recently used entries at the top
  • [NEW] Added line number information to the ChangedFile.Line class
  • [BUG] Default settings work as originally intended
  • [BUG] Fixed NullPointerException that occured when certain settings were blank


v1.0.0 for IDEA 6.0.2 (October 31st 2006)

===========================================

Initial release.

General usage instructions:

The first thing you will need to do is configure the plugin for sending email. Select Code Review Plugin under IDE Settings. Configure your mailserver, email addresses, subject prefix and HTML settings [note that the editing of templates is not yet supported which is why the Template tab is currently disabled]. Now begin a commit of a file or files that you have been editing. You will notice that a new Code Review button appears on the commit dialog. Type in a comment that you want to append to the top of the review email and then click the Code Review button. At this point you should see a dialog that shows a preview of your email along with To/Cc/Bcc/Subject options. Fill them in appropriately and click OK to send the email. Assuming your SMTP server settings were correct the email should now be on its way.

Comments:

12>
rahulsom
Rated: noRate
2011-09-27 23:55:07
I tried sending a code review with 2 files named log4j.xml, in different folders, of course, and got a ZipException and it hangs IDEA because there are 2 dialog boxes - one with the alert and the other with the progress indicator.
.
Anonymous
Rated:
2011-04-28 13:03:27
it will throw an Java exception if we set the Inserted/Deleted/Omitted line color in configuration panel in IDEA 10.

java.lang.InstantiationException:java.awt.Color
.....

Workaround:
Remove below attribute value from code.review.xml.If so, code review plugin will use default value of Color

deletedLineColor
insertedLineColor
omittedLineColor
.
Anonymous
Rated:
2011-04-27 14:01:21
Insert/Delete/Omitted the line is broken in IDEA 10.

Is any one know how to set it in code.review.xml?
.
chris_miller
Rated: noRate
2010-06-30 20:18:08
Anonymous: Thanks for the feedback. The idea behind this plugin is that you should send the code review *before* you check anything in. If people want to see the diffs after you've checked in your changes, normally they can use other 3rd party tools instead (or IDEA itself via eg Changes View -> Repository or Incoming).

Can you clarify how you'd see this plugin working with already commited changes? A "Code Review..." menu entry on the context menu in the Changes View -> Repository window perhaps?
.
Anonymous
Rated:
2010-06-30 07:41:11


The code review works on the checked-out version and its previous version. Once the file checked in, the plugin disables the "core review" button. (Version Control->Commit changes dialog )

In clearcase-ucm, it is more useful to compare with predecessor.

Just Great tool.
.
Anonymous
Rated:
2010-03-26 20:53:34
Great when either my reviewer or I are working from home.
.
Anonymous
Rated:
2009-11-12 12:53:08
Simple but clean and effective. What more could you want?
.
Anonymous
Rated:
2009-08-05 13:46:50
I18N support will be great!
.
Anonymous
Rated: noRate
2009-04-14 18:25:25
I am running IDEA 7.0.5 and getting this error. Can someone advise on what needs to be done to correct this?

Bad version number in .class file [Plugin: V1IdeaPlugin]
.
Anonymous
Rated:
2008-09-17 14:51:14
Very useful plugin, I like it a lot. Could you add support for UTF-8 encoding for the mail body text? I have problems with some Czech characters in the commit message / subject.
.
chris_miller
Rated: noRate
2008-08-20 02:05:59
Hmm I didn't realise 7.0.4 could still run on a 1.5 JRE. Are you on Mac OSX perhaps? My plugin was compiled with JDK 1.6, hence the problem.

I'm away for the next week or so but I'll try to upload a version targeted at 1.5 once I'm back. If you want to try this plugin before then, you could try downloading the source and compile it yourself. Of course it's quite possible I've used some 1.6-specific code in there somewhere too though, I had assumed IDEA had been running on 1.6 across all platforms for quite some time now.
.
Anonymous
Rated: noRate
2008-08-20 01:58:53
UnsupportedClassVersionError - you must be running IDEA on a 1.5 JRE. Hmm, is that the default for IDEA on OSX perhaps? If so I'll have to recompile with -target 1.5 and upload a new version. I'm away for the next week so if you want to use this before then I'd suggest just grabbing the source and building it yourself. Of course there's always the possibility I used 1.6-specific code in there somewhere too - I assumed IDEA had been on 1.6 forever across all platforms!
.
Anonymous
Rated: noRate
2008-08-19 20:56:19
Latest version of Code Review (1.2.1) with latest version of IDEA (7.0.4). No workie.

Bad version number in .class file [Plugin: Code Review]
com.intellij.diagnostic.PluginException: Bad version number in .class file [Plugin: Code Review]
at com.intellij.openapi.components.impl.ComponentManagerImpl$ComponentsRegistry.a(ComponentManagerImpl.java:6)
at com.intellij.openapi.components.impl.ComponentManagerImpl$ComponentsRegistry.a(ComponentManagerImpl.java:51)
at com.intellij.openapi.components.impl.ComponentManagerImpl$ComponentsRegistry.access$100(ComponentManagerImpl.java:53)
at com.intellij.openapi.components.impl.ComponentManagerImpl.a(ComponentManagerImpl.java:143)
at com.intellij.openapi.components.impl.ComponentManagerImpl.initComponents(ComponentManagerImpl.java:160)
at com.intellij.openapi.components.impl.stores.ApplicationStoreImpl.load(ApplicationStoreImpl.java:13)
at com.intellij.openapi.application.impl.ApplicationImpl.load(ApplicationImpl.java:162)
at com.intellij.idea.IdeaApplication.run(IdeaApplication.java:54)
at com.intellij.idea.MainImpl$3.run(MainImpl.java:1)
at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:209)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:461)
at com.intellij.ide.IdeEventQueue.c(IdeEventQueue.java:146)
at com.intellij.ide.IdeEventQueue.b(IdeEventQueue.java:63)
at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:87)
at java.awt.EventDispatchThread.pumpOneEventForHierarchy(EventDispatchThread.java:269)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:190)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:184)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:176)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:110)
Caused by: java.lang.UnsupportedClassVersionError: Bad version number in .class file
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:675)
at java.lang.ClassLoader.defineClass(ClassLoader.java:520)
at com.intellij.util.lang.UrlClassLoader._defineClass(UrlClassLoader.java:132)
at com.intellij.util.lang.UrlClassLoader.defineClass(UrlClassLoader.java:128)
at com.intellij.util.lang.UrlClassLoader._findClass(UrlClassLoader.java:104)
at com.intellij.ide.plugins.cl.PluginClassLoader.loadClassInsideSelf(PluginClassLoader.java:75)
at com.intellij.ide.plugins.cl.PluginClassLoader._loadClass(PluginClassLoader.java:42)
at com.intellij.util.lang.UrlClassLoader.loadClass(UrlClassLoader.java:80)
at java.lang.ClassLoader.loadClass(ClassLoader.java:251)
at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:374)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:242)
at com.intellij.openapi.components.impl.ComponentManagerImpl$ComponentsRegistry.a(ComponentManagerImpl.java:24)
.
Anonymous
Rated:
2007-12-21 06:33:10
Hi,

As previously suggested being able to copy / paste the HTML instead of sending a mail, would be a great feature.

Another useful feature would be to show line numbers and have new lines shown without a line number, so that when u don't show all the code, people can see exactly where the new line is inserted.

Even better would be if you're not showing all the code, it at least displays the method signature that the code change is in.
.
Anonymous
Rated:
2007-04-04 14:31:21
If the "analyse code before commit" checkbox is checked, this plugin gets skipped. you press the code review button, and it runs the analysis, then asks to either commit or review the analysis, and the code review mail sender is never shown
.
12>