The IntelliJ Platform provides tools designed for static code analysis called code inspections, which help the user maintain and clean up code without actually executing it. Custom code inspections can be implemented as IntelliJ Platform plugins. Examples of the plugin approach are the IntelliJ Platform SDK code samples inspection_basics and comparing_references_inspection. In addition, the comparing_references_inspection code sample demonstrates implementing a unit test.
See Inspections topic in the IntelliJ Platform UI Guidelines on naming, writing description, and message texts for inspections.
Creating an Inspection Plugin
The comparing_references_inspection code sample adds a new inspection to the Java | Probable Bugs group in the Inspections list. The inspection reports when the
!= operator is used between Java expressions of reference types.
It illustrates the components for a custom inspection plugin:
Describing an inspection in the plugin configuration file.
Implementing a local inspection class to inspect Java code in the editor.
Creating a visitor to traverse the PSI tree of the Java file being edited, inspecting for problematic syntax.
Implementing an inspection preferences panel to display information about the inspection.
Writing an HTML description of the inspection for display in the inspection preferences panel.
Optionally, create a unit test for the plugin.
Although the IntelliJ Platform SDK code samples illustrate implementations of these components, it is often useful to see examples of inspections implemented in the intellij_community code base. This process can help find inspection descriptions and implementations based on what is visible in the IDE UI. The overall approach works for inspections aimed at other languages as well.
Find an existing inspection that is similar to the one you want to implement in the Object comparison using '==', instead of 'equals()' is very similar topanel. Note the display name of the inspection. For example, the Java/Probable Bugs inspection
Use the display name text as the target for a search within the intellij_community project. This will identify a bundle file if the display name is localized. If it is not localized, the search finds either the plugin.xml file where it is an attribute in the inspection description, or the implementation where it is provided by an overridden method.
In the case of localization, copy the key from the bundle file identified by the search.
Use the key text as the target for a search within the intellij_community project. This search locates the plugin configuration file that describes the inspection.
From the inspection description entry, find the
implementationClasstext as the target of a class search in the intellij_community codebase to find the implementation.
See also Explore the IntelliJ Platform API for more information and strategies.
Creating an Inspection
The comparing_references_inspection code sample reports when the
!= operators are used between Java expressions of reference types. The user can apply a quick fix to change
The details of the
comparing_references_inspection implementation illustrate the components of an inspection plugin.
Plugin Configuration File
comparing_references_inspection is described as a
com.intellij.localInspection extension point in the
comparing_references_inspection plugin configuration (
There exist two types of inspection extensions:
com.intellij.localInspectionextension point is used for inspections that operate on one file at a time, and also operate "on-the-fly" as the user edits the file.
com.intellij.globalInspectionextension point is used for inspections that operate across multiple files, and the associated fix might, for example, refactor code between files.
The minimum inspection setup must declare the
language attribute (unless the inspection works on any supported language). As shown in the
comparing_references_inspection plugin configuration file, other attributes can be defined in the
localInspection element, either with or without localization. In most cases, it is simplest to define the attributes in the plugin configuration file because the underlying parent classes handle most of the class responsibilities based on the configuration file description. Note that some attributes are not displayed to the user, so they are never localized.
If required, inspections can define all the attribute information (except
implementationClass) by overriding methods in the inspection implementation class (not recommended in general).
Inspection Implementation Java Class
Inspection implementations for Java files, like
ComparingReferencesInspection, are often based on the Java class
AbstractBaseJavaLocalInspectionTool base class offers methods to inspect Java classes, fields, and methods.
localInspection types are based on the class
LocalInspectionTool. Examining the class hierarchy for
LocalInspectionTool shows that the IntelliJ Platform provides many child inspection classes for a variety of languages and frameworks. One of these classes is a good basis for a new inspection implementation, but a bespoke implementation can also be based directly on
The primary responsibilities of the inspection implementation class are to provide:
PsiElementVisitorobject to traverse the PSI tree of the file being inspected.
LocalQuickFixclass to fix an identified problem.
JPanelto be displayed in the Inspections settings dialog.
ComparingReferencesInspection class defines two
QUICK_FIX_NAMEdefines the string users see when prompted to apply the quick fix.
CHECKED_CLASSESholds a list of class names of interest to the inspection.
ComparingReferencesInspection methods are discussed in the sections below.
Visitor Implementation Class
The visitor class evaluates whether elements of the file's PSI tree are of interest to an inspection.
ComparingReferencesInspection.buildVisitor() method creates an anonymous visitor class based on
JavaElementVisitor to traverse the PSI tree of the Java file being edited, inspecting for suspect syntax. The anonymous class overrides three methods in particular.
visitReferenceExpression()to prevent any duplicate visitation of reference-type expressions.
visitBinaryExpression(), which does all the heavy lifting. It is called to evaluate a
PsiBinaryExpression, and it checks to see if the operands are
!=, and if the operands are classes relevant to this inspection.
PsiTypeof the operands to determine if they are of interest to this inspection.
Quick Fix Implementation
The quick fix class acts much like an intention, allowing the user to invoke it on the
TextRange) highlighted by the inspection.
ComparingReferencesInspection implementation uses the nested class
CriQuickFix to implement a quick fix based on
CriQuickFix class gives a user the option to change the use of
a == b and
a != b expression to
The heavy lifting is done in
CriQuickFix.applyFix(), which manipulates the PSI tree to convert the expressions. The change to the PSI tree is accomplished by the usual approach to modification:
Creating a new
Substituting the original left and right operands into the new
Replacing the original binary expression with the
Inspection Preferences Panel
The inspection preferences panel is used to display information and provide additional options for the inspection.
The panel created by
ComparingReferencesInspection.createOptionsPanel() just defines a single
JTextField to display in a
JPanel gets added to the Inspections settings dialog when the inspection is selected. The
JTextField allows editing of the
CHECKED_CLASSES field while displayed in the panel.
For simple customization requirements, see also:
The inspection description is an HTML file. The description is displayed in the upper right panel of the Inspections settings dialog when an inspection is selected from the list.
Implicit in using
LocalInspectionTool in the class hierarchy of the inspection implementation means following some conventions.
The inspection description file is expected to be located under $RESOURCES_ROOT_DIRECTORY$/inspectionDescriptions/. If the inspection description file is to be located elsewhere, override
getDescriptionUrl()in the inspection implementation class.
The name of the description file is expected to be the inspection $SHORT_NAME$.html as provided by the inspection description, or the inspection implementation class. If a short name is not provided by the plugin, the IntelliJ Platform computes one by removing
Inspectionsuffix from the implementation class name.
Inspection Unit Test
comparing_references_inspection code sample provides a unit test for the inspection. See the Testing Overview section for general information about plugin testing.
comparing_references_inspection test is based on the
UsefulTestCase class, part of the JUnit framework APIs. This class handles much of the underlying boilerplate for tests.
By convention, the folder test/testData/ contains the test files. The folder contains pairs of files for each test using the name convention ∗.java and ∗.after.java.
In the case of
comparing_references_inspection the test files are Eq.java/Eq.after.java, and Neq.java/Neq.after.java.
comparing_references_inspection tests run the inspection on the ∗.java files, implement the quick fix, and compare the results with the respective ∗.after.java files containing expected result.
Running the Comparing References Inspection Code Sample
See Code Samples on how to set up and run the plugin.
Configuring the Plugin
Once the plugin is launched, you can set the plugin options. You can specify the Java classes to participate in the code inspection and the severity level of the found probable bugs.
On the main menu, open the Java inspections, expand the Probable bugs node, and then click SDK: '==' or '!=' instead of 'equals()'.dialog. In the list of the IntelliJ IDEA
Under Options, you can specify the following plugin settings:
From the Severity list, select the severity level of probable bugs the plugin finds such as Warning, Error, etc.
In the text box under Severity, specify the semicolon separated list of Java classes to participate in this code inspection.
When finished, click OK.
How does it work?
The plugin inspects your code opened in the IntelliJ IDEA editor. The plugin highlights the code fragments where two variables of the reference type are separated by
!= and proposes to replace this code fragment with
In this example, the
str2 are variables of the String type. Invoking SDK: Use equals() replaces: